lua: Allow to set header entry as table to httpCall and respond APIs#7851
lua: Allow to set header entry as table to httpCall and respond APIs#7851mattklein123 merged 4 commits intoenvoyproxy:masterfrom dio:fix-7742
Conversation
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
|
@mattklein123 do we want to return header values of the same header entry key as a table when we do |
I'm concerned this might break existing scripts? WDYT? Perhaps we don't do it for now or provide some type of API ability to return it this way? |
|
@dio please let me know when this is no longer WIP. Thank you! /wait |
|
@mattklein123 yes, think this is ready for review. Thank you! While for getting multiple values from a header name can be done via |
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small nit. Thank you!
/wait
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
|
Oops. Accepting suggestion hurts DCO. Did force pushing. Sorry. |
mattklein123
left a comment
There was a problem hiding this comment.
LGTM post security release
Description: Extends
httpCall()andrespond()APIs to accept headers with values that can be strings or table of strings.Risk Level: Low
Testing: Modified the existing unit tests
Docs Changes: Added
Release Notes: Added
Fixes #7742
Signed-off-by: Dhi Aurrahman dio@tetrate.io