Skip to content

utilize new address type in pgv for better errors #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mythra wants to merge 2 commits into from
Closed

utilize new address type in pgv for better errors #7823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd782c
utilize new address type in pgv for better errors
Aug 3, 2019
a524ab9
update dns addresses to be valid
Aug 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/envoy/api/v2/core/address.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ message SocketAddress {
// address must be an IP (*STATIC* or *EDS* clusters) or a hostname resolved by DNS
// (*STRICT_DNS* or *LOGICAL_DNS* clusters). Address resolution can be customized
// via :ref:`resolver_name <envoy_api_field_core.SocketAddress.resolver_name>`.
string address = 2 [(validate.rules).string.min_bytes = 1];
string address = 2 [(validate.rules).string.address = true];
oneof port_specifier {
option (validate.required) = true;
uint32 port_value = 3 [(validate.rules).uint32.lte = 65535];
Expand Down
4 changes: 2 additions & 2 deletions configs/envoy_service_to_service_v2.template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,11 +398,11 @@ static_resources:
- endpoint:
address:
socket_address:
address: main_website.com
address: main.website.com
port_value: 443
protocol: TCP
tls_context:
sni: www.main_website.com
sni: www.main.website.com
- name: local_service
connect_timeout: 0.25s
type: STATIC
Expand Down
2 changes: 1 addition & 1 deletion examples/lua/envoy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ static_resources:
- endpoint:
address:
socket_address:
address: web_service
address: web.service.com
port_value: 80
admin:
access_log_path: "/dev/null"
Expand Down