config: add init fetch timeout stat#7822
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
@mattklein123 can you PTAL? |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, super useful change. One doc comment.
/wait
| :widths: 1, 1, 2 | ||
|
|
||
| config_reload, Counter, Total API fetches that resulted in a config reload due to a different config | ||
| init_fetch_timeout, Counter, Total :ref:`initial fetch timeouts <envoy_api_field_core.ConfigSource.initial_fetch_timeout>` |
There was a problem hiding this comment.
Thanks, this is a really useful change. However, I think with all of our xDS, it's going to be hard to keep each doc spot up to date. WDYT about maybe have a central doc for "common subscription stats" which we can link to from all the various xDS documentation? cc @htuch
There was a problem hiding this comment.
That makes sense. I can add a central doc for "common subscription stats" - I can do a follow-up if it is easier to review the just doc part or if you think it is better to do it as part of this, I am fine with that too. LMK what you think?
There was a problem hiding this comment.
I think it's fine to do it as part of this change as it's a pretty small change. Thank you!
There was a problem hiding this comment.
@mattklein123 added the subscription_stats page and linked every where else. PTAL.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this is great. Small change request. Also, it seems clear that we are missing docs on a bunch of other xDS APIs most likely... cc @htuch
/wait
| Subscription statistics | ||
| ======================= | ||
|
|
||
| The following statistics are generated for all subscriptions. |
There was a problem hiding this comment.
Can you clarify what a "subscription" is and maybe cross link to relevant xDS/APIv2 docs? Maybe the title of this should be xDS subscription? WDYT? (Basically I think to the casual reader it won't be clear what this page is about)
There was a problem hiding this comment.
Sure. Will do.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
@mattklein123 changed to xds subscription, clarified what subscription with cross reference. PTAL. |
3 participants
Description: Adds a stat for init fetch timeout
Risk Level: Low
Testing: Added
Docs Changes: Updated
Release Notes: Added