Skip to content

dns: use default dns refresh ttl when DNS returns an NXDOMAIN#7815

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
yxue:master
Aug 6, 2019
Merged

dns: use default dns refresh ttl when DNS returns an NXDOMAIN#7815
htuch merged 2 commits intoenvoyproxy:masterfrom
yxue:master

Conversation

@yxue
Copy link
Member

@yxue yxue commented Aug 2, 2019

Signed-off-by: Yan Xue yxyan@google.com

Description: Use default DNS refresh TTL when DNS returns an NXDOMAIN
Risk Level: Medium
Testing: unit test, manual test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: #7808

Signed-off-by: Yan Xue <yxyan@google.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch
Copy link
Member

htuch commented Aug 6, 2019

@crazyxy can you merge master to fix some unrelated CI issues?

@htuch htuch added the waiting label Aug 6, 2019
Signed-off-by: crazyxy <yxyan@google.com>
@yxue
Copy link
Member Author

yxue commented Aug 6, 2019

/azp run envoy-macos

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7815 in repo envoyproxy/envoy

@htuch
Copy link
Member

htuch commented Aug 6, 2019

/azp run envoy-macos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@htuch htuch merged commit 41c4244 into envoyproxy:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants