docs: link to GetEnvoy.io for pre-built binaries#7814
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Aug 5, 2019
Merged
docs: link to GetEnvoy.io for pre-built binaries#7814mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
mattklein123
requested changes
Aug 3, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for adding this. A few comments.
/wait
docs/root/start/start.rst
Outdated
| Envoy does not currently provide separate pre-built binaries, but does provide Docker images. This is | ||
| the fastest way to get started using Envoy. Should you wish to use Envoy outside of a | ||
| Docker container, you will need to :ref:`build it <building>`. | ||
| Envoy provides official :ref:`pre-built Docker images <install_binaries>` and other pre-built binaries |
Member
There was a problem hiding this comment.
I would not link directly to GetEnvoy here, but instead just rephrase and link to the other page where everything is described. Then we only have to keep one place up to date.
docs/root/install/building.rst
Outdated
| `GetEnvoy.io <https://www.getenvoy.io/>`_. | ||
|
|
||
| We will consider producing additional binary types depending on community interest in helping with | ||
| CI, packaging, etc. Please open an `issue <https://github.com/envoyproxy/envoy/issues>`_ in GitHub |
Member
There was a problem hiding this comment.
Maybe add a GH link to getenvoy here and tell people to open issue against that repo for prebuilt binaries for different platforms? WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Risk Level:
Testing:
Docs Changes: Docs only
Release Notes:
Fixes #5668