Skip to content

docs: fix custom header example#7806

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
christianladron:docs-fix-custom-header
Aug 2, 2019
Merged

docs: fix custom header example#7806
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
christianladron:docs-fix-custom-header

Conversation

@christianladron
Copy link
Contributor

@christianladron christianladron commented Aug 1, 2019

Description:
The example shows the request_headers_to_add in the RouteAction, and this should be in the Route

Risk Level: Low
Testing: N/A
Docs Changes: This is a doc change
Release Notes: N/A

Christian Ladrón de Guevara Reyes christian@datank.ai

The example shows the request_headers_to_add in the RouteAction, and this should be in the Route

Signed-off-by: Christian Ladrón de Guevara Reyes <christian@datank.ai>
@christianladron christianladron force-pushed the docs-fix-custom-header branch from f5b04bc to 58d79ec Compare August 1, 2019 21:17
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Yes, this (setting request_header_to_add to RouteAction) is deprecated since 1.8.0.

@mattklein123 mattklein123 merged commit 95a2b26 into envoyproxy:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants