codec: add metadata_not_supported_error to HTTP/1 codec stats#7801
codec: add metadata_not_supported_error to HTTP/1 codec stats#7801mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yang Song <yasong@google.com>
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM modulo needing docs.
Once they're in you can /assign Matt for final pass
| switch (type) { | ||
| case Type::HTTP1: { | ||
| codec_ = std::make_unique<Http1::ClientConnectionImpl>(*connection_, *this); | ||
| codec_ = std::make_unique<Http1::ClientConnectionImpl>(*connection_, |
There was a problem hiding this comment.
Mind updating docs/root/configuration/http_conn_man/stats.rst ?
Each codec has the option of adding per-codec statistics. Currently only http2 has codec stats. needs updating, and a section on Http1 codec stats?
Signed-off-by: Yang Song <yasong@google.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with one small doc comment. Thank you! Please also merge master to fix CI.
/wait
| :header: Name, Type, Description | ||
| :widths: 1, 1, 2 | ||
|
|
||
| metadata_not_supported_error, Counter, Total number of parsing metadata with http1 error |
There was a problem hiding this comment.
I don't think this description is quite right. Maybe something like "Total number of metadata frames dropped during HTTP/1 encoding" or something like that?
Signed-off-by: Yang Song <yasong@google.com>
Signed-off-by: Yang Song <yasong@google.com>
|
/retest |
|
🔨 rebuilding |
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
Description: introduce stats to HTTP/1 codec. Add metadata_not_supported_error.
Risk Level: Low. stats change only.
Testing: Unit test.
Docs Changes: N/A
Release Notes: