Merged
Conversation
Let the config override the Stackdriver address. This can be used for proxying and testing. Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
Contributor
|
cc @objectiser @moderation this moves opencensus to master tip (which was requested in a previous PR). |
These come from tracing.grpc.pb.h which is autogenerated by the protobuf compiler. Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
htuch
suggested changes
Aug 1, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, one major comment on Stackdriver integration...
/wait
htuch
approved these changes
Aug 2, 2019
Member
|
@g-easy can you merge master, LGTM. |
Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the config override the Stackdriver address. This can be used for
proxying and testing.
Signed-off-by: Emil Mikulic g-easy@users.noreply.github.com