http: add a test case where metadata exceed size limit#7747
Merged
alyssawilk merged 5 commits intoenvoyproxy:masterfrom Aug 1, 2019
Merged
http: add a test case where metadata exceed size limit#7747alyssawilk merged 5 commits intoenvoyproxy:masterfrom
alyssawilk merged 5 commits intoenvoyproxy:masterfrom
Conversation
added 4 commits
July 27, 2019 09:08
Signed-off-by: Yang Song <yasong@google.com>
Signed-off-by: Yang Song <yasong@google.com>
Signed-off-by: Yang Song <yasong@google.com>
Signed-off-by: Yang Song <yasong@google.com>
Contributor
Author
|
cc @birenroy |
alyssawilk
suggested changes
Jul 31, 2019
| return 0; | ||
| } | ||
|
|
||
| if (stream != nullptr) { |
Contributor
There was a problem hiding this comment.
Thanks for adding the new test!
I'm sold on the test being useful but for the codec changes, I'd prefer rather than the codec have to know the behavior of the HCM, that the HCM actually trigger this by doing something like onDecoderDestroy to the codec if we think the lifetime of the streams in HCM and codec differs.
Alternate if the lifetime of the streams does not differ, I think this PR adds more risk than it removes and we should simply add the test.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! I see. Reverted the codec change.
Signed-off-by: Yang Song <yasong@google.com>
alyssawilk
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add a test to cover the case where nghttp2 returns process error because metadata exceed size limit. The PR also adds a few asserts to verify when nghttp2 returns error, no more data is passed to filters (a bug fixed by#6852). This PR is a followup for #6842.
Risk Level: Low.
Testing: N/A
Docs Changes: N/A
Release Notes: N/A