Fix RuntimeFromNonWorkerThreads#7746
Merged
alyssawilk merged 5 commits intoenvoyproxy:masterfrom Jul 29, 2019
Merged
Conversation
This is a follow-up to e61681d. While working on envoyproxy#7574, I am getting consistent timeouts for this test. I think it happens because the code on the main thread runs slower than the code on the reader thread. My fix is to properly acquire and release the lock on each step, to ensure they are properly interlaced. That is: 1) read from reader 2) write from writer 3) read new value from reader 4) read new value from writer To repro the timeout, I added a sleep before step 2. After this change, I can't repro anymore. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
cc: @alyssawilk |
Member
Author
|
/retest |
|
🔨 rebuilding |
added 2 commits
July 28, 2019 19:59
This actually ensures that we only wait() if we should. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
alyssawilk
reviewed
Jul 29, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Sorry for the flakes, and thanks for the fix. Two minor nits and you're good to go!
* while -> if * remove unneeded outer scope Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
/retest |
|
🐴 hold your horses - no failures detected, yet. |
Member
Author
|
/retest |
|
🤷♀️ nothing to rebuild. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to e61681d. While working on #7574, I am getting
consistent timeouts for this test.
I think it happens because the code on the main thread runs slower
than the code on the reader thread.
My fix is to properly acquire and release the lock on each step,
to ensure they are properly sequenced. That is:
To repro the timeout, I added a sleep before step 2. After this change,
I can't repro anymore.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com