update filter example with what we use for tests#7737
Merged
lizan merged 3 commits intoenvoyproxy:masterfrom Jul 26, 2019
Merged
update filter example with what we use for tests#7737lizan merged 3 commits intoenvoyproxy:masterfrom
lizan merged 3 commits intoenvoyproxy:masterfrom
Conversation
this forces the same workspace file we use for tests: - https://github.com/envoyproxy/envoy/blob/14c5371/ci/build_setup.sh#L75 to be pushed to the envoy-filter-example. this will allow not having to file a manual PR to fix the build, such as: - envoyproxy/envoy-filter-example#95 Signed-off-by: Cynthia Coan <ccoan@instructure.com>
5c64272 to
5dc607e
Compare
Signed-off-by: Cynthia Coan <ccoan@instructure.com>
lizan
reviewed
Jul 26, 2019
Signed-off-by: Cynthia Coan <ccoan@instructure.com>
Member
|
You may run this locally by setting CIRCLE_BRANCH=master, though it should fail at pushing but you can see the repo. |
Member
Author
|
I had to comment the line the line: However after commenting that out I was able to get to the With a proper workspace: That can build envoy |
Member
|
Looks like it works: https://circleci.com/gh/envoyproxy/envoy/256692 |
Member
Author
|
Phew. Always glad to see something work I can’t test all the way through. Hopefully this will keep filter working. Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
this forces the same workspace file we use for tests:
to be pushed to the envoy-filter-example. this will allow not having
to file a manual PR to fix the build, such as:
Risk Level: Low
Testing: Not sure how I can test this manually. Perhaps someone as part of the envoy org can run the script manually?
Docs Changes: None
Release Notes: None