runtime: changing snapshot access to be const#7677
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Jul 22, 2019
Merged
runtime: changing snapshot access to be const#7677alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
pushed a commit
that referenced
this pull request
Aug 13, 2019
LukeShu
pushed a commit
to gravitee-io/envoy
that referenced
this pull request
Aug 26, 2019
This is a precursor to envoyproxy#7601 just to land the API change more quickly and make sure it sticks. Risk Level: Low Testing: existing unit tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
LSChyi
pushed a commit
to LSChyi/envoy
that referenced
this pull request
Sep 24, 2019
…yproxy#26) This is a precursor to envoyproxy#7601 just to land the API change more quickly and make sure it sticks. Risk Level: Low Testing: existing unit tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: LSChyi <alan81920@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor to #7601 just to land the API change more quickly and make sure it sticks.
Risk Level: Low
Testing: existing unit tests
Docs Changes: n/a
Release Notes: n/a