Skip to content

build: fix coverage upload #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zuercher wants to merge 1 commit into from
Closed

build: fix coverage upload #7609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions ci/coverage_publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,21 @@ if [ "${CIRCLECI}" != "true" ]; then
exit 0
fi

[[ -z "${ENVOY_BUILD_DIR}" ]] && ENVOY_BUILD_DIR=/build
COVERAGE_FILE="${ENVOY_BUILD_DIR}/envoy/generated/coverage/index.html"
Copy link
Copy Markdown
Member

@lizan lizan Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update link in line 32 too? feel free to close #7608.


if [ ! -f "${COVERAGE_FILE}" ]; then
echo "ERROR: Coverage file not found."
exit 1
fi

echo "Found coverage report: ${COVERAGE_FILE}"

# available for master builds
if [ -z "$CIRCLE_PR_NUMBER" ]
then
echo "Uploading coverage report..."

[[ -z "${ENVOY_BUILD_DIR}" ]] && ENVOY_BUILD_DIR=/build
COVERAGE_FILE="${ENVOY_BUILD_DIR}/envoy/generated/coverage/coverage.html"

if [ ! -f "${COVERAGE_FILE}" ]; then
echo "ERROR: Coverage file not found."
exit 1
fi

BRANCH_NAME="${CIRCLE_BRANCH}"
COVERAGE_DIR="$(dirname "${COVERAGE_FILE}")"
S3_LOCATION="lyft-envoy/coverage/report-${BRANCH_NAME}"
Expand Down