test: deflake ads_integration_test#7584
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 16, 2019
Merged
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
zuercher
approved these changes
Jul 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes ads_integration_test flakes with tsan, due to ThreadSanitizer: data race.
Adds in appropriate compareDiscoveryRequest calls to wait for DiscoveryRequests after DiscoveryResponses.
Risk Level: Low
Testing: Flake rate went from 5/400 to 0/400 with bazel.tsan
Fixes Issue #7576
Signed-off-by: Asra Ali asraa@google.com