Skip to content

bazel: Update to 0.28.0#7533

Merged
alyssawilk merged 2 commits intoenvoyproxy:masterfrom
keith:ks/update-bazel
Jul 11, 2019
Merged

bazel: Update to 0.28.0#7533
alyssawilk merged 2 commits intoenvoyproxy:masterfrom
keith:ks/update-bazel

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Jul 11, 2019

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith
Copy link
Copy Markdown
Member Author

keith commented Jul 11, 2019

I might have some follow ups here, we'll see what CI says

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Copy link
Copy Markdown
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keith. I'm in favor of merging this before 1.11.0 release as 0.27.0 has some drawbacks, i.e. official release doesn't run on Trusty, CentOS. Defer merging to @alyssawilk

@alyssawilk
Copy link
Copy Markdown
Contributor

I defer right on back to you and @htuch as I think you two can assess risk better
I'm fine with it landing if you two are Ok with it :-)

@alyssawilk
Copy link
Copy Markdown
Contributor

got a verbal thumbs up from Harvey. Let's do it!

@alyssawilk alyssawilk merged commit ea41ce1 into envoyproxy:master Jul 11, 2019
@keith keith deleted the ks/update-bazel branch July 11, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants