config dump, listeners are added to warming list if workers are not started yet

[incfly]

Signed-off-by: Jianfei Hu jianfeih@google.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: Listeners config dump changed to warming_listeners if the workers are not started.
Risk Level: Low
Testing: Unit test, (existing unit test is good enough, with workers started before and after)
Docs Changes:
Release Notes: Listeners config dump changed to warming_listeners if the workers are not started.
[Optional Fixes #Issue] #6904
[Optional Deprecated:]

[incfly]

/cc @silentdai @asraa @mattklein123 for review.

[mattklein123]

Thanks, this is low risk and makes sense to me. @asraa @silentdai any concerns?

[lambdai]

Make perfect sense. Thank you!
/lgtm

[asraa]

This looks good to me.

Mind if you add in
EXPECT_EQ(getListenersConfigDump().dynamic_warming_listeners().size(), 1)
here in ads_integration_test to just note that the pre-server initialization listeners are added as active but dumped as warming?

envoy/test/integration/ads_integration_test.cc

Lines 968 to 971 in 79b071c

	sendDiscoveryResponse<envoy::api::v2::Listener>(
	Config::TypeUrl::get().Listener, {buildListener("listener_0", "route_config_0")},
	{buildListener("listener_0", "route_config_0")}, {}, "1");
	test_server_->waitForGaugeGe("listener_manager.total_listeners_active", 1);

[mattklein123]

Waiting on @asraa comment.

/wait

[incfly]

@asraa Done.

[asraa]

Thank you!

[incfly]

/retest

[repokitteh-read-only]

🔨 rebuilding ci/circleci: clang_tidy (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #7511 (comment) was created by @incfly.

see: more, trace.

[incfly]

/retest

[repokitteh-read-only]

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #7511 (comment) was created by @incfly.

see: more, trace.

[incfly]

Tests now all passed. @mattklein123 could you take another look or this is ready to go?

[mattklein123]

Thanks, will merge once 1.11 is cut.