router: Add RETRY_ON_RESET retry policy#7505
Conversation
Signed-off-by: Matt Hoey <matt.hoey@okta.com>
|
/retest |
|
🤷♀️ nothing to rebuild. |
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks, this seems good to me modulo the one doc comment. Coverage seems to be good according to the generated coverage report, so I don't think additional testing is required.
Re deprecation of the old policies I'm not sure if we have a good deprecation path for them, so I suspect we might need to keep them around for the foreseeable future to avoid breaking existing users. @alyssawilk @mattklein123 WDYT?
| or 504. | ||
|
|
||
| reset | ||
| Envoy will attempt a retry if the upstream server does not respond due to a reset. |
There was a problem hiding this comment.
The wording here is a bit off I think: the upstream might have started responding but trigger before it finishes (for example, the upstream server could crash mid-response). Maybe reuse the wording from the 5xx retry policy?
There was a problem hiding this comment.
@snowp Which part of the wording for 5xx exactly? This doesn't trigger if any 5xx response code comes back, right?
There was a problem hiding this comment.
i mean the language about resets, the does not respond at all (disconnect/reset/read timeout) bit
There was a problem hiding this comment.
Ahh, gotcha. Updated.
IMO it's not worth the user churn and I would probably just leave the existing functionality. |
matthoey-okta
left a comment
matthoey-okta
left a comment
There was a problem hiding this comment.
I'm heading to Europe for a few weeks and won't be able to work on this. If I can get the change to the wording (or if someone else can make the change on my behalf, I'm good with that too,) I can make it in a few hours or I can pick this up when I get back?
| or 504. | ||
|
|
||
| reset | ||
| Envoy will attempt a retry if the upstream server does not respond due to a reset. |
There was a problem hiding this comment.
@snowp Which part of the wording for 5xx exactly? This doesn't trigger if any 5xx response code comes back, right?
Signed-off-by: Matt Hoey <matt.hoey@okta.com>
|
You all left the blueprint. Happy to have contributed to one of my favorite projects. |
3 participants
Signed-off-by: Matt Hoey matt.hoey@okta.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Adds a retry policy for resets. Not a developer, let alone a c++ dev but gave it my best shot. Had a few questions:
Risk Level: Low
Testing: I added one. I can try to do a build in the morning. Honestly I thought we were experiencing this problem, but I found out after I wrote it that we don't have the issue so I'm unsure how to test.
Docs Changes: Pretty much anywhere I found gateway error I added reset documentation. Open to feedback on it.
Release Notes: n/a
Fixes #6726
[Optional Deprecated:]