forward proxy: per host SNI and SAN verification#7466
Merged
mattklein123 merged 12 commits intomasterfrom Jul 12, 2019
Merged
Conversation
1) Implement auto SAN/SNI setting on a per-host basis. 2) Cleanup some v1 config translation. Part of #1606 Signed-off-by: Matt Klein <mklein@lyft.com>
mattklein123
commented
Jul 3, 2019
Member
Author
|
@PiotrSikora @lizan I want to improve test coverage a bit, but can you give me some early feedback on the TLS code when you get a chance? cc @alyssawilk |
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
reviewed
Jul 8, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
I'm happy with the overall plan - having a wrapper class feels a bit heavyweight but I think it allows for maximal code reuse and code reuse makes me happy :-)
test/extensions/filters/http/dynamic_forward_proxy/proxy_filter_integration_test.cc
Show resolved
Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@alyssawilk updated per comments. I regenerated all of the upstream certs because they all need to be signed by the CA. I could probably hack up the script by hand to reuse the existing CA cert, but I'm not sure the effort is worth it. LMK. |
lizan
reviewed
Jul 9, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@lizan thanks for the great suggestion. This is much better! PTAL, cc @PiotrSikora also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1606
Risk Level: Low
Testing: Integration test
Docs Changes: Done
Release Notes: N/A