http/1.1 codec: Rejects requests w/ invalid HTTP header values#7306

Merged

alyssawilk merged 25 commits intoenvoyproxy:masterfrom

dcarney:dcarney/reject-invalid-http-headers

Jul 15, 2019

Commits on Jul 11, 2019

Makes the http connection manager reject requests w/ invalid header values
dcarney
committed
Fixes tests; making them use new absl::string_view type
dcarney
committed
Fixes test to use absl::string_view
dcarney
committed
Makes HTTP header validation opt-in behavior
dcarney
committed
Eliminates the creation of a temporary std::string obj
dcarney
committed
Uses plain boolean over proto-wrapped boolean type for config property
dcarney
committed
Fixes reference in doc string for HTTP connection manager proto.
dcarney
committed
Fixes mock obj for HTTP conn manager utility tests
dcarney
committed
Adds overrides for new validateHeaders() method in fuzz test
dcarney
committed
http conn manager: reverts HTTP header checking changes, based on PR feedback
dcarney
committed
header utility: replaces header validation func with one that operates on individual values
dcarney
committed
HTTP 1.1 codec: adds runtime-guarded header value validation
dcarney
committed
Adds test coverage for HTTP 1.1 codec header validation
dcarney
committed
Updates version history from latest master, mentions runtime guard string used.
dcarney
committed
Updates version history to show only the diff for this PR
dcarney
committed
Removes response code const
dcarney
committed
Adds HTTP/1.1 codec c-tor overloads that take header validation as an arg, per alyssawilk
dcarney
committed
Incorporates latest upstream changes to the runtime loader
dcarney
committed
Incorporates PR feedback
dcarney
committed
Fixes version_history after latest master rebase
dcarney
committed
Fixes CI test failure, for codec test that passes locally
dcarney
committed
s/validate_header_values/strict_header_validation/
dcarney
committed
Moves release note to 1.12.0
dcarney
committed
Adds a TODO for @alyssawilk, per our Envoy Slack convo
dcarney
committed

Commits on Jul 15, 2019

Moves runtime value check to the proper codec creation block
dcarney
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http/1.1 codec: Rejects requests w/ invalid HTTP header values#7306

http/1.1 codec: Rejects requests w/ invalid HTTP header values#7306
alyssawilk merged 25 commits intoenvoyproxy:masterfrom
dcarney:dcarney/reject-invalid-http-headers

Commits on Jul 11, 2019

Makes the http connection manager reject requests w/ invalid header values

Fixes tests; making them use new absl::string_view type

Fixes test to use absl::string_view

Makes HTTP header validation opt-in behavior

Eliminates the creation of a temporary std::string obj

Uses plain boolean over proto-wrapped boolean type for config property

Fixes reference in doc string for HTTP connection manager proto.

Fixes mock obj for HTTP conn manager utility tests

Adds overrides for new validateHeaders() method in fuzz test

http conn manager: reverts HTTP header checking changes, based on PR feedback

header utility: replaces header validation func with one that operates on individual values

HTTP 1.1 codec: adds runtime-guarded header value validation

Adds test coverage for HTTP 1.1 codec header validation

Updates version history from latest master, mentions runtime guard string used.

Updates version history to show only the diff for this PR

Removes response code const

Adds HTTP/1.1 codec c-tor overloads that take header validation as an arg, per alyssawilk

Incorporates latest upstream changes to the runtime loader

Incorporates PR feedback

Fixes version_history after latest master rebase

Fixes CI test failure, for codec test that passes locally

s/validate_header_values/strict_header_validation/

Moves release note to 1.12.0

Adds a TODO for @alyssawilk, per our Envoy Slack convo

Commits on Jul 15, 2019

Moves runtime value check to the proper codec creation block