Make HTTP/1.0 responses without Connection: keep-alive mean close.#7124
Merged
mattklein123 merged 9 commits intoenvoyproxy:masterfrom Jun 5, 2019
Merged
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
alyssawilk
reviewed
Jun 3, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Thanks for tackling this! Would you be up for rephrasing the release notes to make it clear this is an Envoy-upstream issue? I believe the Envoy-downstream behavior is currently correct and I was confused about what was going wrong until I started reading your fix :-)
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
mattklein123
requested changes
Jun 4, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with some comments.
/wait
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
mattklein123
requested changes
Jun 4, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with a few comments. Thanks for iterating.
/wait
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
alyssawilk
previously approved these changes
Jun 5, 2019
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Excellent, thanks for the fix! LGTM pending Matt's sign-off
Signed-off-by: John Plevyak <jplevyak@gmail.com>
…ve-means-close Signed-off-by: John Plevyak <jplevyak@gmail.com>
Member
|
/retest |
|
🔨 rebuilding |
duderino
pushed a commit
to istio/envoy
that referenced
this pull request
Jun 12, 2019
1.2 cherry-pick: Make HTTP/1.0 responses without Connection: keep-alive mean close. (envoyproxy#7124)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Currently HTTP/1.0 requests without a Connection: close cause the connection to remain open. This does not conform to the HTTP/1.0 specification. Connections without Connection: keep-alive should be expected to close. Failing to do so can result in 503 errors if a new request is sent on that connection before the close is detected.
Risk Level: Medium
Testing: 24 hours with 5 applications
Docs Changes:
Release Notes: HTTP/1.0 responses without Connection: keep-alive now means close.
[Optional Fixes #Issue] #7123
[Optional Deprecated:]