remove use of std::tuple in gzip_filter_test to avoid compilation err…#7099
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom May 29, 2019
Merged
remove use of std::tuple in gzip_filter_test to avoid compilation err…#7099htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
…or in libstdc+++ Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Contributor
Author
|
@htuch could you please take a look? |
dnoe
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or in libstdc+++
Signed-off-by: Xin Zhuang stevenzzz@google.com
Description: with libstdc++ the the std::tuple constructor picked by a {x,y,z} parameter is "explicit tuple(TP_&&...) ", which causes a compilation error, remove the usage of std::tuple to make the test code more compatible w/ libstdc++.
Risk Level: LOW
Testing: Unit test.
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]