fuzz: add header string filter in utility_fuzz_test and cleanup dead code#7088
Merged
htuch merged 8 commits intoenvoyproxy:masterfrom May 29, 2019
Merged
fuzz: add header string filter in utility_fuzz_test and cleanup dead code#7088htuch merged 8 commits intoenvoyproxy:masterfrom
htuch merged 8 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Contributor
Author
|
/review htuch |
Member
|
Please merge master to pick up #7090 |
Merge to pick up envoyproxy#7090 Signed-off-by: Asra Ali <asraa@google.com>
htuch
suggested changes
May 28, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo minor changes.
/wait
| oneof utility_selector { | ||
| string parse_query_string = 1; | ||
| CookiesKey parse_cookie_value = 2; | ||
| CookiesKey has_set_cookie = 3; |
Member
There was a problem hiding this comment.
Can you mark this field as reserved 3; to avoid later reuse?
test/common/http/common_fuzz.h
Outdated
| namespace Envoy { | ||
|
|
||
| // The HeaderMap code assumes that input does not contain certain characters, and | ||
| // this is validated by the HTTP parser. The fuzzer will create strings with |
test/common/http/common_fuzz.h
Outdated
| // before we get to anything interesting. | ||
| // | ||
| // This method will replace any of those characters found with spaces. | ||
| std::string filterInvalidCharacters(absl::string_view string); |
Member
There was a problem hiding this comment.
Suggest renaming to replaceInvalidCharacters
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds header string filter on cookie headers to fix crashing fuzz tests.
Removes dead hasSetCookie code, and associated tests and fuzz tests.
Fixes oss-fuzz issue
https://oss-fuzz.com/testcase-detail/5735325211557888
Risk Level: Low.
Testing: Corpus entry added for crashing input.
Signed-off-by: Asra Ali asraa@google.com