[test] convert bootstrap test configs to v2#7065
Merged
mattklein123 merged 13 commits intoenvoyproxy:masterfrom May 26, 2019
Merged
[test] convert bootstrap test configs to v2#7065mattklein123 merged 13 commits intoenvoyproxy:masterfrom
mattklein123 merged 13 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Member
Author
|
hmm, not sure about the doc failure since this doesn't touch docs, there's 1 warning in the output: |
Signed-off-by: Derek Argueta <dereka@pinterest.com>
dio
reviewed
May 24, 2019
| connect_timeout: 0.250s | ||
| type: static | ||
| lb_policy: round_robin | ||
| hosts: |
Member
There was a problem hiding this comment.
Should we directly convert hosts to load_assignment here? (since hosts is deprecated).
Member
Author
There was a problem hiding this comment.
Done. I did this for most cases. There's a few spots where v1-consuming functions are still used (i.e. configDump used in ClusterManagerImplTest.InitializeOrder) but I'd prefer to handle those in a follow-up PR given the LoC already in this PR.
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Member
Author
|
Thanks @dio for the doc fix! |
mattklein123
approved these changes
May 26, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
So amazing. Thank you!!! Now if you are up for it, let's make the spreadsheet and split this up. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Converts test configs for Bootstrap messages to v2. This also deletes code that depended on v1 Bootstrap translation. Bootstrap is a pretty fundamental config type, so this opens the door to fully cleaning out various other v1-v2 translation functions that were called by
translateBootstrapsuch astranslateAddressandtranslateCluster. For issue #6362.Risk Level: Low
Testing: Included
Docs Changes: N/A
Release Notes: N/A