[WIP] health check: fix more fallout from inline deletion change#6987
Closed
mattklein123 wants to merge 1 commit intomasterfrom
Closed
[WIP] health check: fix more fallout from inline deletion change#6987mattklein123 wants to merge 1 commit intomasterfrom
mattklein123 wants to merge 1 commit intomasterfrom
Conversation
Calling clearDeferredDeleteList() in the health check destructor is very hard to reason about and can immediately delete items in the list that need to stay deferred. This change reworks the logic to no longer require doing that. This is much easier to reason about. Fixes #6951 Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@snowp per offline convo do you mind taking this over and adding your cleaned up crashing test? |
Contributor
|
Yep will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling clearDeferredDeleteList() in the health check destructor
is very hard to reason about and can immediately delete items
in the list that need to stay deferred. This change reworks the
logic to no longer require doing that. This is much easier to
reason about.
Fixes #6951
Risk Level: Low
Testing: TBD
Docs Changes: N/A
Release Notes: N/A