health check: fix additional regression from #6765#6942
Merged
mattklein123 merged 1 commit intomasterfrom May 15, 2019
Merged
Conversation
If we inline delete a host during a failure callback we need to account for the connection being cleaned up prior to handling 'connection: close' headers. Signed-off-by: Matt Klein <mklein@lyft.com>
snowp
approved these changes
May 14, 2019
|
|
||
| request_encoder_ = &client_->newStream(*this); | ||
| request_encoder_->getStream().addCallbacks(*this); | ||
| Http::StreamEncoder* request_encoder = &client_->newStream(*this); |
Contributor
There was a problem hiding this comment.
Is this just a cleanup or does is this part of the fix?
Member
Author
There was a problem hiding this comment.
It's just a cleanup. The member variable was not used so I deleted it.
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
May 15, 2019
This is a follow-up to envoyproxy#6942. This makes it a bit more readable. We spent some time debugging this too, so it would be nice to ensure it's readable next time we bump into something around this code surface :-) Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
pushed a commit
that referenced
this pull request
May 15, 2019
This is a follow-up to #6942. This makes it a bit more readable. We spent some time debugging this too, so it would be nice to ensure it's readable next time we bump into something around this code surface :-) Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we inline delete a host during a failure callback we need to
account for the connection being cleaned up prior to handling
'connection: close' headers.
Risk Level: Low
Testing: New UT and modified integration test
Docs Changes: N/A
Release Notes: N/A