Use std::make_shared in other locations where we were 'manually' creating the objects.#689
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 4, 2017
Merged
Conversation
mattklein123
approved these changes
Apr 4, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I think there might be some other cases too. I've been meaning to go through and fix at least the cases that are in the hot path. But thanks, looks good.
Contributor
Author
|
I think I got all but one of that matched the pattern "return .SharedPtr.new Foo(.).;" There are a lot of cases of unique_ptrs initialized without the use of something like make_unique, but make_unique isn't in C++ 11, so I didn't bother with trying to address those. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
As of envoyproxy/envoy-mobile#616, this is no longer used or necessary since it's handled by the router. Resolves envoyproxy/envoy-mobile#643. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
As of envoyproxy/envoy-mobile#616, this is no longer used or necessary since it's handled by the router. Resolves envoyproxy/envoy-mobile#643. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Upgrading Docusaurus version to 3.8 Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.