Skip to content

test: adding some debug logs to diagnose hang #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 4 commits into from
May 16, 2019
Merged

test: adding some debug logs to diagnose hang #6875

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e2fb42
test: adding some debug logs
alyssawilk May 9, 2019
010cbd6
Merge branch 'master' into hang
alyssawilk May 13, 2019
ce263d2
review comments
alyssawilk May 13, 2019
5e26c38
more logs
alyssawilk May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/integration/load_stats_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,12 @@ TEST_P(LoadStatsIntegrationTest, LocalityWeighted) {
locality_weighted_lb_ = true;
initialize();

// Debug logs for #6874
std::cerr << "Waiting for load stats stream.\n";

@lizan lizan May 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need use std::endl as end of line so it flushes the buffer.

waitForLoadStatsStream();
std::cerr << "Waiting for load stats request.\n";
waitForLoadStatsRequest({});
std::cerr << "Done waiting.\n";
loadstats_stream_->startGrpcStream();

requestLoadStatsResponse({"cluster_0"});
Expand All @@ -473,7 +477,9 @@ TEST_P(LoadStatsIntegrationTest, LocalityWeighted) {
sendAndReceiveUpstream(0);

// Verify we get the expect request distribution.
std::cerr << "Waiting for load stats request 2.\n";
waitForLoadStatsRequest({localityStats("winter", 4, 0, 0), localityStats("dragon", 2, 0, 0)});
std::cerr << "Done waiting.\n";

EXPECT_EQ(1, test_server_->counter("load_reporter.requests")->value());
// On slow machines, more than one load stats response may be pushed while we are simulating load.
Expand Down