ci: refactor external dep build/install scripts.#687
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 4, 2017
Merged
ci: refactor external dep build/install scripts.#687mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
The motivation for this is that we would like to allow developers to perform local installation of
Envoy dependencies as prebuilts, similar to CI.
build_and_install_deps.sh now does the build/install into $THIRDPARTY_{SRC,BUILD} via recursive
make. This provides a significant speed boost (2 minutes total build time for all dependencies on my
workstation) and the top-level make is able to keep track of when stuff needs to be rebuilt as
dependencies change over time (see comment at the top of Makefile).
Verified with {debug, coverage, bazel.debug} runs locally against the resulting CI Docker image.
mattklein123
reviewed
Apr 4, 2017
| # TODO(htuch): These dependencies should be installed into distinct --prefix directories, so we can | ||
| # easily blow away the lib/ and include/ install directories when we upgrade version. | ||
|
|
||
| all: $(THIRDPARTY_DEPS)/libevent.dep \ |
Member
There was a problem hiding this comment.
nit: Can we fix the whitespace indent in this file. It's making my OCD flair up.
mattklein123
reviewed
Apr 4, 2017
| cd boringssl | ||
| git reset --hard b87c80300647c2c0311c1489a104470e099f1531 | ||
| cmake . | ||
| make |
Member
There was a problem hiding this comment.
For full job server support aren't you supposed to do $(MAKE) ? (Similar elsewhere)
Member
Author
There was a problem hiding this comment.
By prefixing the shell invocation line with +, the top-level make puts the make coordination flags in the environment, so no need to do anything special in the script.
mattklein123
approved these changes
Apr 4, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
When this passes tests I will merge and then build/push a new build image just to verify things.
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message**
Add model name field to backend ref. This allows users pass a different
model name to the backend from the one that was provided in the original
request. This is particularly useful for cross-provided failover and
load balancing.
For example: If a user has provisioned Claude 3.5 Sonnet on both AWS and
GCP they can setup a rule that will load balance across them:
```yaml
apiVersion: aigateway.envoyproxy.io/v1alpha1
kind: AIGatewayRoute
metadata:
name: test-route
namespace: ai-gateway
spec:
targetRefs:
- group: gateway.networking.k8s.io
kind: Gateway
name: eg
schema:
name: OpenAI
rules:
- matches:
- headers:
- type: Exact
name: x-ai-eg-model
value: claude-3-5-sonnet-v2
backendRefs:
- name: aws-backend
- name: gcp-backend
```
Since the both providers will have a different name/model identifier for
the provisioned endpoint the above configuration will not work. This PR
makes it possible to add a `modelName` on the backend ref which
specifies the providers name for the model.
With the `modelName` property we can support this use-case as follows:
```yaml
apiVersion: aigateway.envoyproxy.io/v1alpha1
kind: AIGatewayRoute
metadata:
name: test-route
namespace: ai-gateway
spec:
targetRefs:
- group: gateway.networking.k8s.io
kind: Gateway
name: eg
schema:
name: OpenAI
rules:
- matches:
- headers:
- type: Exact
name: x-ai-eg-model
value: claude-3-5-sonnet-v2
backendRefs:
- name: aws-backend
modelName: arn:aws:bedrock:us-west-2:123456789012:provisioned-model/abc123xyz
- name: gcp-backend
modelName: claude-3-5-sonnet-v2@20241022
```
---------
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@users.noreply.github.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this is that we would like to allow developers to perform local installation of
Envoy dependencies as prebuilts, similar to CI.
build_and_install_deps.sh now does the build/install into $THIRDPARTY_{SRC,BUILD} via recursive
make. This provides a significant speed boost (2 minutes total build time for all dependencies on my
workstation) and the top-level make is able to keep track of when stuff needs to be rebuilt as
dependencies change over time (see comment at the top of Makefile).
Verified with {debug, coverage, bazel.debug} runs locally against the resulting CI Docker image.