ci: update build image #6866
ci: update build image #6866
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
|
@lizan is this (the mac build) hanging?
|
ci/run_clang_tidy.sh
Outdated
| @@ -16,6 +16,9 @@ trap cleanup EXIT | |||
| # Writing them into bazelrc | |||
| echo "build ${BAZEL_BUILD_OPTIONS}" >> .bazelrc | |||
|
|
|||
| # TODO(lizan): remove this once https://github.com/grailbio/bazel-compilation-database/issues/25 is fixed. | |||
| echo "build --incompatible_disable_legacy_cc_provider=false" >> .bazelrc | |||
There was a problem hiding this comment.
FWIW, I only just read how this .bazelrc thing works today; it's pretty funky but I would much rather we switched to another build directory and created an ephemeral .bazelrc, e.g. what happens if you interrupt the local clang-tidy?
There was a problem hiding this comment.
Well the trap EXIT worked, though we don't need this any more as upstream issue is resolved, and we don't have ci WORKSPACE anymore.
There was a problem hiding this comment.
It worked providing you get the signal; if you nuke the Docker image or something, you don't get that.
ci/do_ci.sh
Outdated
| @@ -215,7 +215,7 @@ elif [[ "$1" == "bazel.coverage" ]]; then | |||
|
|
|||
| # gcovr is a pain to run with `bazel run`, so package it up into a | |||
| # relocatable and hermetic-ish .par file. | |||
| bazel build @com_github_gcovr_gcovr//:gcovr.par | |||
| bazel build --incompatible_remove_old_python_version_api=false @com_github_gcovr_gcovr//:gcovr.par | |||
There was a problem hiding this comment.
Is there a tracking bug to clean this one up? Hoping not to be too surprised at a Bazel point release.
Signed-off-by: Lizan Zhou <[email protected]>
|
@lizan failing clang_tidy on CI. |
Signed-off-by: Lizan Zhou <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
Hi @htuch @lizan, can we move forward with this cl? Is there a concrete problem or just lack of time and more urgent priorities? Regarding Regarding Thanks! |
stale
bot
removed
the
stale
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Lizan Zhou <[email protected]>
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Lizan Zhou <[email protected]>
Description: Regression in #6866. k8-dbg/bin is excluded to ignore generated files but virtual_includes are there too. Risk Level: Low Testing: CI 🙏 Docs Changes: Release Notes: Fixes #7474 Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou [email protected]
Description:
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes: