Skip to content

connection: don't pass read data to filters when in delayed close. #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 6 commits into from
May 14, 2019
Merged

connection: don't pass read data to filters when in delayed close. #6852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e1c4fa
connection: don't pass read data to filters when in delayed close.
htuch May 1, 2019
ae40fde
Disable read rather than not forward.
htuch May 8, 2019
a61500d
Experiment with unconditional read disable in close().
htuch May 8, 2019
06d8363
Validated inDelayedClose() in onRead().
htuch May 9, 2019
906f807
Merge remote-tracking branch 'upstream/master' into hcm-fix-delayed-c…
htuch May 13, 2019
b849e01
Andres comments.
htuch May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/common/network/connection_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,9 @@ void ConnectionImpl::onRead(uint64_t read_buffer_size) {
read_end_stream_raised_ = true;
}

filter_manager_.onRead();
if (!inDelayedClose()) {
Comment thread
htuch marked this conversation as resolved.
Outdated
filter_manager_.onRead();
}
}

void ConnectionImpl::enableHalfClose(bool enabled) {
Expand Down
Loading