health check: handle host deletion during failure callback#6813
Merged
mattklein123 merged 3 commits intomasterfrom May 6, 2019
Merged
health check: handle host deletion during failure callback#6813mattklein123 merged 3 commits intomasterfrom
mattklein123 merged 3 commits intomasterfrom
Conversation
Member
Author
|
cc @lita |
Signed-off-by: Matt Klein <mklein@lyft.com>
snowp
approved these changes
May 6, 2019
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
LGTM, seems like a good solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #6765 due to not handling recursive
deletion inside of a failure callback.
Fixes #6806
Risk Level: Medium, changes active HC session destruction flow.
Testing: New integration test which crashes before this fix, and a new UT.
Docs Changes: N/A
Release Notes: N/A