stats: Add a new class StatNamePool to abstract some StatName memory management.#6757
Merged
jmarantz merged 8 commits intoenvoyproxy:masterfrom May 7, 2019
Merged
Conversation
…mory management. Signed-off-by: Joshua Marantz <jmarantz@google.com>
ambuc
previously approved these changes
May 1, 2019
Contributor
ambuc
left a comment
ambuc
left a comment
There was a problem hiding this comment.
LGTM, some comments with documentation asks.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
changed the title
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
commented
May 1, 2019
Contributor
Author
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
I decided to rename it from StatNameManagedContainer to StatNamePool.
Contributor
Author
|
@envoyproxy/senior-maintainers any takers for a final review? This is a pretty simple refactor I added to make #6733 easier. This one should be pretty mechanical. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
May 6, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, generally looks good, 2 questions.
/wait-any
…ge and explicit dtor. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
May 6, 2019
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Member
|
@jmarantz you will need to merge master again to fix CI I think. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: While implementing the explicit management of StatName for HTTP codes in #6733 I found an opportunity for abstracting the memory management for a group of StatNames, using friendly RAII semantics at the group level. This also simplifies a bunch of existing unit tests.
Risk Level: low
Testing: //test/common/stats/...
Docs Changes: n/a
Release Notes: n/a