upstream: do not stabilize host when failed by EDS#6714
Merged
Conversation
Previously if an EDS cluster was using active health checking, a host would only be removed if it was removed both from EDS as well as failed active HC. This change allows a host to be removed if it is first failed by EDS, and then removed by EDS. This provides a management server a mechanism to force removal of a host even when the host may still be passing active health checking. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
Apr 26, 2019
Previously if an EDS cluster was using active health checking, a host would only be removed if it was removed both from EDS as well as failed active HC. This change allows a host to be removed if it is first failed by EDS, and then removed by EDS. This provides a management server a mechanism to force removal of a host even when the host may still be passing active health checking. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if an EDS cluster was using active health checking,
a host would only be removed if it was removed both from EDS as
well as failed active HC. This change allows a host to be removed
if it is first failed by EDS, and then removed by EDS. This provides
a management server a mechanism to force removal of a host even
when the host may still be passing active health checking.
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: Added