filter state: replace std::map with absl::flat_hash_map in FilterStateImpl#6705
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Apr 25, 2019
Merged
filter state: replace std::map with absl::flat_hash_map in FilterStateImpl#6705htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kyu Chang <kyuc@google.com>
htuch
suggested changes
Apr 25, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, this is much cleaner. Can you confirm with @AndresGuedez (Envoy google3 import on-call this week) that the string changes are safe?
/wait-any
Contributor
This is safe; the problems I ran into were due to a missing constructor in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kyu Chang kyuc@google.com
Description: Change the type of
data_storage_from std::map to absl::flat_hash_map which is unordered map and supports heterogeneous lookup natively. Cleanup absl::string_view to std::string conversion in the cc file.Risk Level: Low
Testing: unit test
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]