event: fix race condition in DispatcherImpl#6701
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 24, 2019
mergeconflict:dispatcher_impl_race
Merged
event: fix race condition in DispatcherImpl#6701mattklein123 merged 2 commits intoenvoyproxy:masterfrom mergeconflict:dispatcher_impl_race
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mergeconflict:dispatcher_impl_race
Conversation
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Author
|
/review @AndresGuedez @mattklein123 |
mattklein123
requested changes
Apr 24, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with tiny nit.
/wait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix race between
initializeStatsandrunin DispatcherImpl by consolidating these to the dispatcher's thread.Risk Level: low
Testing: dispatcher_impl_test and worker_impl_test, with --runs_per_test=1000 (in Google's environment where the issue was found).
Docs Changes: n/a
Release Notes: n/a
Fixes: #6699
Signed-off-by: Dan Rosen mergeconflict@google.com