Skip to content

fuzz: buffer fuzzer for new implementation.#6698

Merged
htuch merged 4 commits intoenvoyproxy:masterfrom
htuch:fuzz-new-buffer
Apr 24, 2019
Merged

fuzz: buffer fuzzer for new implementation.#6698
htuch merged 4 commits intoenvoyproxy:masterfrom
htuch:fuzz-new-buffer

Conversation

@htuch
Copy link
Member

@htuch htuch commented Apr 24, 2019

Parameterizes existing fuzzer to yield a second fuzzer than can independently fuzz the new
implementation.

Risk level: Low
Testing: bazel test //test/common/buffer/...

Signed-off-by: Harvey Tuch htuch@google.com

Parameterizes existing fuzzer to yield a second fuzzer than can independently fuzz the new
implementation.

Risk level: Low
Testing: bazel test //test/common/buffer/...

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Apr 24, 2019

Note to reviewers, there has been no substantive change to the buffer fuzzer, other than the lines related to setting old implementation. This PR currently SIGSEGVs with the new implementation, looking into it.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Apr 24, 2019

SIGSEGV is now fixed, so this should be good to review and merge.

htuch added 2 commits April 24, 2019 15:54
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excited to see what this turns up.

@htuch htuch merged commit 7ddd765 into envoyproxy:master Apr 24, 2019
@htuch htuch deleted the fuzz-new-buffer branch April 24, 2019 22:12
@htuch
Copy link
Member Author

htuch commented Apr 24, 2019

Merged to intercept the nightly fuzzer run; @brian-pane if you had any feedback I'm happy to address in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants