Skip to content

docs: fix link in pull request template #6679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 1 commit into from
Apr 23, 2019
Merged

docs: fix link in pull request template #6679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](./PULL_REQUESTS.md)
Copy link
Member

@junr03 junr03 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This linking already works?

Copy link
Member Author

@dschaller dschaller Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works if you are viewing the file off master but when you open a pull request the link attempts to show a diff from PULL_REQUEST.md. :)

You can click the link above to see it redirects to https://github.com/envoyproxy/envoy/compare/PULL_REQUESTS.md?expand=1

For an explanation of how to fill out the fields, please see the relevant section
in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md)

Description:
Risk Level:
Expand Down