(do not merge) Investigation of coverage failures in Kafka codec#6652
Closed
adamkotwasinski wants to merge 49 commits intoenvoyproxy:masterfrom
Closed
(do not merge) Investigation of coverage failures in Kafka codec#6652adamkotwasinski wants to merge 49 commits intoenvoyproxy:masterfrom
adamkotwasinski wants to merge 49 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-codec-investigation
branch
from
5091911 to
1c63244
Compare
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-codec-investigation
branch
from
96fce8b to
783a2f5
Compare
Contributor
Author
|
/wait |
adamkotwasinski
force-pushed
the
kafka-codec-investigation
branch
from
3d2670b to
202250a
Compare
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-codec-investigation
branch
from
202250a to
b2f7cb7
Compare
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/wait |
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-codec-investigation
branch
from
9bfddeb to
3733a58
Compare
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/wait |
Member
|
@adamkotwasinski I'm not sure what the issue is exactly, but if the generated files are giving you issues, can you just exclude them from coverage? |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
…erage ignore them Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
…'external' directory Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/wait |
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Contributor
Author
|
/wait |
Contributor
Author
|
post mortem resolution:
possible cause:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge this PR
Related to coverage build failures #4950
Want to run them on CI infrastructure, as I have noticed that locally the issues might disappear when I disable the tests (running on mac introduces yet another variable too)