quiche: add epoll_server for testing #6650
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #pragma once | ||
|
|
||
| // NOLINT(namespace-envoy) | ||
|
|
||
| // This file is part of the QUICHE platform implementation, and is not to be | ||
| // consumed or referenced directly by other Envoy code. It serves purely as a | ||
| // porting layer for QUICHE. | ||
|
|
||
| #include <sys/socket.h> | ||
|
|
||
| #include <algorithm> | ||
|
|
||
| #include "envoy/network/address.h" | ||
|
|
||
| #include "test/test_common/environment.h" | ||
|
|
||
| namespace epoll_server { | ||
|
|
||
| namespace { | ||
|
|
||
| int addressFamilyUnderTestHelper() { | ||
| std::vector<Envoy::Network::Address::IpVersion> versions = | ||
| Envoy::TestEnvironment::getIpVersionsForTest(); | ||
|
Contributor
There was a problem hiding this comment. How about using std::find for clarity? if (std::find(versions.begin(), versions.end(), Envoy::Network::Address::IpVersion::v4) { if (std::find(versions.begin(), versions.end(), Envoy::Network::Address::IpVersion::v6) { return -1;
Contributor
There was a problem hiding this comment. hmm, my code in comment doesn't actually work, it should be if (std::find(versions.begin(), versions.end(), Envoy::Network::Address::IpVersion::v4) != versions.end()) { |
||
| if (std::find(versions.begin(), versions.end(), Envoy::Network::Address::IpVersion::v4) != | ||
| versions.end()) { | ||
| return AF_INET; | ||
| } | ||
| if (std::find(versions.begin(), versions.end(), Envoy::Network::Address::IpVersion::v6) != | ||
| versions.end()) { | ||
| return AF_INET6; | ||
| } | ||
| return -1; | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| // Returns the address family to be used for test. Return v4 if the environment | ||
| // supports v4 only or both v4 and v6. Otherwise return v6 or an invalid value. | ||
| int AddressFamilyUnderTestImpl() { | ||
|
Contributor
There was a problem hiding this comment. Looks like this is confusingly named, but doing the right thing.
Contributor
Author
There was a problem hiding this comment. Renaming requires upstream change. I added a comment here for the return value. |
||
| static const int version = addressFamilyUnderTestHelper(); | ||
| return version; | ||
| } | ||
|
|
||
| } // namespace epoll_server | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to explicitly add the
envoy_coptsif this is aenvoy_cc_test_library?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed actually. Removed.