Skip to content

http timeout integration test: wait for 10ms for upstream reset #6646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Apr 19, 2019
Merged

http timeout integration test: wait for 10ms for upstream reset #6646

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76c297
http timeout integration test: wait for 10ms for upstream reset
mpuncel Apr 18, 2019
b618070
increase timeout to 15s
mpuncel Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/http_timeout_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TEST_P(HttpTimeoutIntegrationTest, GlobalTimeout) {

// Ensure we got a timeout downstream and canceled the upstream request.
response->waitForHeaders();
ASSERT_TRUE(upstream_request_->waitForReset(std::chrono::milliseconds(0)));
ASSERT_TRUE(upstream_request_->waitForReset(std::chrono::milliseconds(10)));
Comment thread
mpuncel marked this conversation as resolved.
Outdated

codec_client_->close();

Expand Down