quiche: Implement some TODOs in quic_endian_impl.h#6644
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Apr 20, 2019
Merged
quiche: Implement some TODOs in quic_endian_impl.h#6644mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Bin Wu <wub@google.com>
Contributor
Author
|
/assign @danzh2010 |
Contributor
Author
|
/assign @mattklein123 |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Apr 22, 2019
* master: thread: remove ThreadFactorySingleton (envoyproxy#6658) router: support offseting downstream provided grpc timeout (envoyproxy#6628) router: defer per try timeout until downstream request is done (envoyproxy#6643) update bazel readme for clang-format-8 on mac (envoyproxy#6660) Implement some TODOs in quic_endian_impl.h (envoyproxy#6644) docs: add aspell to mac dependencies to fix check format script (envoyproxy#6661) config: fix delta xDS's use of (un)subscribe fields, more explicit protocol spec (envoyproxy#6545) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implement QuicEndianImpl::HostToNet64, QuicEndianImpl::NetToHost64 and QuicEndianImpl::HostIsLittleEndian on top of common/common/byte_order.h. Remove corresponding TODOs.
Risk Level: minimum, code not used yet.
Testing:
Enabled QUICHE platform tests in quic_endian_test.cc.
Docs Changes: none
Release Notes: none