cluster manager: destroy warming clusters during shutdown()#6577
Merged
cluster manager: destroy warming clusters during shutdown()#6577
Conversation
Fixes #6513. This issue has existed for quite some time, so I'm unclear why we just started seeing this. It's possible it's chance and it's also possible it's in some way related to the init changes, but either way, this is the correct fix. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
/retest |
|
🔨 rebuilding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6513.
This issue has existed for quite some time, so I'm unclear why we
just started seeing this. It's possible it's chance and it's also
possible it's in some way related to the init changes, but either
way, this is the correct fix.
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A