quiche: Implement http2 macros#6567
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 12, 2019
Merged
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @mattklein123 |
mattklein123
approved these changes
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement HTTP2_DIE_IF_NULL and HTTP2_UNREACHABLE: https://quiche.googlesource.com/quiche/+/refs/heads/master/http2/platform/api/http2_macros.h
This two interfaces doesn't have clear documentation about their usage. But at a glance, HTTP2_DIE_IF_NULL(ptr) is used as a function to check if passed-in argument is a nullptr, if not return the pointer, see its usage in chromium code: https://cs.chromium.org/chromium/src/net/third_party/quiche/src/http2/hpack/decoder/hpack_whole_entry_buffer.cc?type=cs&g=0&l=22, and HTTP2_UNREACHABLE() is used as a function too: https://cs.chromium.org/chromium/src/net/third_party/quiche/src/http2/decoder/http2_frame_decoder.cc?rcl=9e84364c1893473f994688884920e9a32d7e02df&l=73
Risk Level: low
Testing: Added new test in test/extensions/quic_listeners/quiche/platform:http2_platform_test
Part of #2557