extensions/filters: ext_authz filter to use StopAllIterationAndWatermark status#6565
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Apr 15, 2019
Merged
extensions/filters: ext_authz filter to use StopAllIterationAndWatermark status#6565lizan merged 1 commit intoenvoyproxy:masterfrom
lizan merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yang Song <yasong@google.com>
soya3129
changed the title
gsagula
reviewed
Apr 13, 2019
| return filter_return_ == FilterReturn::StopDecoding ? Http::FilterHeadersStatus::StopIteration | ||
| : Http::FilterHeadersStatus::Continue; | ||
| return filter_return_ == FilterReturn::StopDecoding | ||
| ? Http::FilterHeadersStatus::StopAllIterationAndWatermark |
Member
There was a problem hiding this comment.
If I understood correctly, StopAllIterationAndWatermark will hold headers, data and trailers. It will also return an HTTP 413 if the buffer limit is exceeded. If that's correct, isn't a change of behaviour?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! StopAllIterationAndWatermark behaves the same as if StopIterationAndWater is returned by decodeData() (the original behavior), instead of returning 413, reading will be disabled until buffered data are processed. Does it make sense?
Member
There was a problem hiding this comment.
No problem! Sorry, I was looking at the description for StopAllIterationAndBuffer. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Song yasong@google.com
Description: Use StopAllIteration status for ext_authz filter.
Risk Level: high.
Testing: unit testing.
Docs Changes: No behavior change expected.
Release Notes: n/a