Add support for redis 5 zpopmin and zpopmax#6563
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Apr 12, 2019
Merged
Add support for redis 5 zpopmin and zpopmax#6563mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
April 11, 2019 15:28
Signed-off-by: Maxime Bedard <maxime.bedard@shopify.com>
Signed-off-by: Maxime Bedard <maxime.bedard@shopify.com>
mattklein123
approved these changes
Apr 11, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks. @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg @msukalski look ok?
Contributor
|
LGTM |
mattklein123
requested changes
Apr 11, 2019
docs/root/intro/version_history.rst
Outdated
| 1.11.0 (Pending) | ||
| ================ | ||
| * upstream: added :ref:`upstream_cx_pool_overflow <config_cluster_manager_cluster_stats>` for the connection pool circuit breaker. | ||
| * redis: add support for zpopmin and zpopmax commands. |
Member
There was a problem hiding this comment.
Sorry just missed this. Can you alpha sort? Sorry and than you.
Member
There was a problem hiding this comment.
Sorry I actually meant alpha sort this entry in the version history, but thanks for the other one also. :)
Might as well merge master again also.
/wait
Signed-off-by: Maxime Bedard <maxime.bedard@shopify.com>
added 2 commits
April 12, 2019 12:17
Signed-off-by: Maxime Bedard <maxime.bedard@shopify.com>
Signed-off-by: Maxime Bedard <maxime.bedard@shopify.com>
Signed-off-by: Maxime Bedard <maxime.bedard@shopify.com>
Contributor
Author
|
Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add support for redis 5 zpopmin and zpopmax. They behave as a simple comment as the first argument is the key of the sorted set.
Risk Level: low
Testing: N/A
Docs Changes: Updated list of supported commands
Release Notes: Added new commands to release note.