redis: fix asking output for ask redirection support#6543
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Apr 14, 2019
Merged
redis: fix asking output for ask redirection support#6543mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
- issue separate, preceding "asking" command instead of prefixing "asking" to the redirected command. - combined all derived requests' onChildRedirection() methods into a single method. - fixed affected unit and integration tests. Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
Contributor
Author
|
build_image failed with: Allocating a remote Docker Engine |
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
- adding additional unit and integration negative tests for coverage Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
- extended tests for coverage gap Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
Contributor
Author
|
100% line coverage of modified code achieved with the last push. |
Member
Contributor
|
Ok I'm on it |
Contributor
|
LGTM, one minor comment. |
mattklein123
requested changes
Apr 12, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with some nits.
/wait
source/extensions/filters/network/redis_proxy/command_splitter_impl.cc
Outdated
Show resolved
Hide resolved
source/extensions/filters/network/redis_proxy/command_splitter_impl.cc
Outdated
Show resolved
Hide resolved
source/extensions/filters/network/redis_proxy/command_splitter_impl.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue separate, preceding "asking" command instead of prefixing
"asking" to the redirected command.
combined all derived requests' onChildRedirection() methods into
a single method.
fixed affected unit and integration tests.
Signed-off-by: Mitch Sukalski mitch.sukalski@workday.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
For Redis ASK redirection support, the "asking" command is now a separate command issued before the redirected command, instead of being prepended to the redirected command itself ("asking" is now encoded at its own array of a single bulkstring, "asking" -- instead of being added as the first array element of the redirected command). The unit and integration tests have been updated to reflect this change, and additional optimization was done to remove redundant onChildRedirection() methods for command splitter request types derived from FragmentRequest.
Risk Level: low
Testing: unit and integration tests as well as direct verification via redis-cli to a Redis cluster
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]