upstream: add connection pool circuit breaker stats#6516
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Apr 11, 2019
Merged
upstream: add connection pool circuit breaker stats#6516mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Users will want to know how often connection pool overflows are happening. Count them. Signed-off-by: Kyle Larose <kyle@agilicus.com>
Signed-off-by: Kyle Larose <kyle@agilicus.com>
Signed-off-by: Kyle Larose <kyle@agilicus.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Kyle Larose <kyle@agilicus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: add connection pool circuit breaker stats
We want to know how often the connection pool circuit breaker trips as a hint that the limit may need to be increased. Add a stat to do so.
Risk Level: Medium
Testing: UT + Integration test
Docs Changes: Documented in the stats overview as well as the circuit breaker docs.
Release Notes: Added a note
Other notes: I didn't add a counter for the total number of connection pools. I can do that too if we're not worried about the memory consumption involved.