ext_authz: removed unnecessary assert from onSuccess gRPC client#6505
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Apr 11, 2019
Merged
ext_authz: removed unnecessary assert from onSuccess gRPC client#6505mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
April 6, 2019 17:35
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
mattklein123
requested changes
Apr 8, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with small comments.
/wait
Signed-off-by: Gabriel <gsagula@gmail.com>
…ove-assert Signed-off-by: Gabriel gsagula@gmail.com
alyssawilk
pushed a commit
that referenced
this pull request
May 7, 2019
…6821) Description: PR #6211 updated the documentation of CheckResponse.status to reflect Envoy's actual behavior at the time. Later, PR #6505 changed that behavior to be in-line with the pre-6211 docs. So, revert that part of PR #6211. Risk Level: Low Testing: None Docs Changes: Inline in API protos Release Notes: none Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since
Grpc::Status::GrpcStatus::Unknownis a valid status, there is no reason for crashing Envoy when this code is received from a gRPC authorization response.Risk Level: Low
Testing: No
Docs Changes: No
Release Notes: Yes
Fixes #6210
Signed-off-by: Gabriel gsagula@gmail.com