Skip to content

stats: add/test heterogenous set of StatNameStorage objects.#6504

Merged
jmarantz merged 16 commits intoenvoyproxy:masterfrom
jmarantz:shared-stat-name-storage-set
Apr 22, 2019
Merged

stats: add/test heterogenous set of StatNameStorage objects.#6504
jmarantz merged 16 commits intoenvoyproxy:masterfrom
jmarantz:shared-stat-name-storage-set

Conversation

@jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Apr 6, 2019

Description: This PR breaks out one of the concepts from #6161 -- an efficient mechanism for remembering a set of StatNames to reject, to use for caching the results of the stats-matcher.
Risk Level: low -- not used yet.
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

jmarantz added 3 commits April 5, 2019 10:53
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ured, this is not necessary.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz requested a review from ambuc April 6, 2019 21:54
jmarantz added 2 commits April 6, 2019 18:55
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz added a commit to jmarantz/envoy that referenced this pull request Apr 7, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

jmarantz commented Apr 8, 2019

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: asan (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6504 (comment) was created by @jmarantz.

see: more, trace.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
ambuc
ambuc previously approved these changes Apr 15, 2019
Copy link
Contributor

@ambuc ambuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…r clang).

Signed-off-by: Joshua Marantz <jmarantz@google.com>
…on a no-release assert.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
…s helpful to test swap().

Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz added a commit to jmarantz/envoy that referenced this pull request Apr 21, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)
🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6504 (comment) was created by @jmarantz.

see: more, trace.

…nt state.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@htuch htuch self-assigned this Apr 22, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: asan (failed build)
🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6504 (comment) was created by @jmarantz.

see: more, trace.

@jmarantz jmarantz merged commit 629bbfb into envoyproxy:master Apr 22, 2019
@jmarantz jmarantz deleted the shared-stat-name-storage-set branch April 22, 2019 19:47
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 24, 2019
* master:
  docs: add extension policy (envoyproxy#6678)
  ext_authz: added ability to detect partial request body data (envoyproxy#6583)
  version_history.rst: jwt_authn change missed 1.10.0 (envoyproxy#6684)
  docs: fix link in pull request template (envoyproxy#6679)
  Explicitly convert absl::string_view to std::string. (envoyproxy#6687)
  docs: improving watermark docs/comments (envoyproxy#6683)
  http filter: add CSRF filter (envoyproxy#6470)
  event: reintroduce dispatcher stats (envoyproxy#6659)
  security: postmortem for CVE-2019-990[01] (envoyproxy#6597)
  Improve build rules for (test only) library quic_port_utils. (envoyproxy#6672)
  spell check: skip unsupported extensions when called with a file (envoyproxy#6648)
  Changed TestHooks to ListenerHooks (envoyproxy#6642)
  proto: move extension-specific linking validation into extensions (envoyproxy#6657)
  stats: add/test heterogenous set of StatNameStorage objects. (envoyproxy#6504)
  docs: move xds protocol to rst (envoyproxy#6670)
  fix version history order (envoyproxy#6671)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants