api: fix bazel query again#6463
api: fix bazel query again#6463lizan merged 1 commit intoenvoyproxy:masterfrom mergeconflict:fix_bazel_query_again
Conversation
Signed-off-by: Dan Rosen <mergeconflict@google.com>
|
/review @lizan |
mattklein123
left a comment
There was a problem hiding this comment.
Is there any way we can run this command in CI to catch issues?
|
Yeah, would be ideal to just make this part of the |
|
What do you think if we make /api a fully considered as a external repository? |
+1, I also made a partial effort at #6186 |
|
Yes #6229 as well, as a consequence they need to be in one PR, but I haven't resolve the CI Issue with that. |
|
Of course landing this PR is the priority. If you guys don't mind, I can work on /api isolation to prevent future breakage. |
|
Sure feel free to take it. @silentdai |
Description: fix "bazel query ..." again.
Risk Level: low
Testing: "bazel query ..." works.
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Dan Rosen mergeconflict@google.com